Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-736355: [HTAP] Add Retry Context to retried request #633

Merged
merged 15 commits into from
Sep 22, 2023
Merged

SNOW-736355: [HTAP] Add Retry Context to retried request #633

merged 15 commits into from
Sep 22, 2023

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Sep 13, 2023 •
edited
Loading

Description

Please explain the changes you made here.

  • Added 'includeRetryReason' option.
  • Replaced 'retry' parameter with Retrycount, and added RetryReason when the option is enabled.
  • Added connection testing code.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Sep 18, 2023
View reviewed changes
lib/constants/error_messages.js Outdated Show resolved Hide resolved
lib/errors.js Show resolved Hide resolved
lib/connection/statement.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review September 21, 2023 20:15
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner September 21, 2023 20:15
sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Sep 22, 2023
View reviewed changes
test/unit/util_test.js Outdated Show resolved Hide resolved
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 22, 2023
View reviewed changes
lib/connection/connection_config.js Outdated Show resolved Hide resolved
lib/connection/connection_config.js Outdated Show resolved Hide resolved
lib/connection/statement.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
test/unit/util_test.js Outdated Show resolved Hide resolved
test/unit/util_test.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested review from sfc-gh-pmotacki and removed request for a user September 22, 2023 09:15
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit fc83f25 into master Sep 22, 2023
5 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the retriedrequest branch September 22, 2023 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf left review comments

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-ext-simba-jy @sfc-gh-ext-simba-lf @sfc-gh-dprzybysz @sfc-gh-pmotacki